commit | 9e8fa4994e5501f1d1e4d445a3896d4ad65bd215 | [log] [tgz] |
---|---|---|
author | Mingyu Lei <leimy@chromium.org> | Mon Jun 30 17:05:15 2025 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Jun 30 17:05:15 2025 |
tree | ca4db5c0f1ce8183a7839a25cdd5efa71ee0dfb5 | |
parent | 0483ee5154c05f07f253ac75e3fde4ebde264af4 [diff] |
[M138] Revert "Reland "FSA: Only normalize the hardcoded rules once during initialization"" This reverts commit dda97247b0f3c95d3b4690e95234e8c4b09666cd. Reason for revert: https://g-issues.chromium.org/issues/428455312 Bug: 395595606 Original change's description: > Reland "FSA: Only normalize the hardcoded rules once during initialization" > > This is a reland of commit 37141c231485b178e8d9a6064916a1016311f207 > > Fix the flaky tests that caused the revert by waiting for the path reset > to be completed. See patch 4 vs patch 1 for the changes. > > Original change's description: > > FSA: Only normalize the hardcoded rules once during initialization > > > > Path normalization impacts the performance of the block rules check, and > > it was done for every block path for each check. In this CL, the path > > normalization for the hard coded rules will be done only once when > > initializing the `ChromeFileSystemAccessPermissionContext`. > > > > It's safe to keep a cache for the resolved paths since the path service > > should provide constant path results throughout a live session > > (https://source.chromium.org/chromium/chromium/src/+/main:base/path_service.h;l=39-40;drc=9d69367493326eeb650386198de90b220824702b) > > > > Manually tested that the block paths are set up with the same values > > with the main branch. > > > > Change-Id: Ia02d773640a5c44c6c55143efde28184243efd0c > > Bug: 395595606 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6428707 > > Reviewed-by: Nathan Memmott <memmott@chromium.org> > > Commit-Queue: Mingyu Lei <leimy@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1456846} > > Bug: 395595606 > Change-Id: Icb2ddc57bce726074936b9879f438f143ccff468 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6556022 > Commit-Queue: Mingyu Lei <leimy@chromium.org> > Reviewed-by: Nathan Memmott <memmott@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1461937} Bug: 395595606 Change-Id: Ifa7da24656ca0113225e3b190d2980122adea301 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6687234 Reviewed-by: Harry Souders <harrysouders@google.com> Owners-Override: Harry Souders <harrysouders@google.com> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/branch-heads/7204@{#1924} Cr-Branched-From: d5de512dc9dc8ddfe4e6d71b0637578bb6158683-refs/heads/main@{#1465706}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.