commit 9eac581096f51ce14fb5bc280163526cd329540b
author Alison Maher <almaher@microsoft.com> Thu Nov 18 22:04:25 2021
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Nov 18 22:04:25 2021
tree 03b44b4278e887e44aae28caa6ced6cf2ef4492f
parent 387c4e6e98820988ee01a69e6649dd3d46521268

[FlexNG] GiveItemsFinalPositionAndSizeForFragmentation

Refactor GiveItemsFinalPositionAndSize() such that the fragmentation
specific logic is moved into a new method called
GiveItemsFinalPositionAndSizeForFragmentation(). With this update, we
will end up looping over items twice in the first fragmentainer - once
with the initial call to GiveItemsFinalPositionAndSize(), and second
when GiveItemsFinalPositionAndSizeForFragmentation() is called. In
subsequent fragmentainers, only the latter will be called.

The main reason that we call GiveItemsFinalPositionAndSize() initially
in the case of fragmentation is that only a subset of item information
is stored in between fragmentainers, so certain info needs to be
propagated for all items before moving on to the next fragmentainer.
This propagation will only happen in GiveItemsFinalPositionAndSize().

We will also need to know the original block-size of an item in order
to tell if an item has expanded due to fragmentation. The plan will be
to store this on the NGFlexItem in a follow-up change. This info will
be set on the item in GiveItemsFinalPositionAndSize(), at which point
we will know the non-fragmented block-size of all items (including
stretched items).

A couple of things to point out:
- GiveItemsFinalPositionAndSize() no longer uses the NGFlexItemIterator,
since we do not need to make various fragmentation related checks in
that method while looping.
- Since buttons and sliders are not fragmentable, only adjust the
baselines for those in GiveItemsFinalPositionAndSize().

This CL should not result in any functional change.

Bug: 660611
Change-Id: I2a4acf7981a658e45958f59a3579d7d6405f2100
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3288786
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#943269}