Google Git
Sign in
chromium / chromium / src / 9f01846fb4d640d81034c0d66a7f5059cda9e296
commit9f01846fb4d640d81034c0d66a7f5059cda9e296[log] [tgz]
authorSohail Rajdev <sorajdev@microsoft.com>Wed Jan 29 02:18:49 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jan 29 02:18:49 2025
tree67192bc22a52064cc4509b3fa008a7de7707310b
parent76274b5fed11720c394ed5c065b3506b653f7c5b [diff]
Avoid copying DisableReasonSet in ExtensionPrefs::ReplaceDisableReasons

This CL updates ExtensionPrefs::ReplaceDisableReasons to accept a const-
reference to DisableReasonSet, instead of passing the set by value.

A code comment in ExtensionService has also been updated to adhere to
the C++ styleguide.

These changes address the review comments on the last patchset in
crrev.com/c/6167689

Bug: 372186532
Change-Id: If53205e0ee4ba0da6fa421e8e0190bb2ef50b9f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6205820
Reviewed-by: Emilia Paz <emiliapaz@chromium.org>
Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org>
Commit-Queue: Sohail Rajdev <sorajdev@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1412675}
3 files changed
tree: 67192bc22a52064cc4509b3fa008a7de7707310b
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. description
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.