commit | 9f12c72efeb0fd9ee617f700ee1ab946c242cdbc | [log] [tgz] |
---|---|---|
author | Tim Judkins <tjudkins@google.com> | Wed Mar 23 20:19:30 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Mar 23 20:19:30 2022 |
tree | 94c3b2d02f574f7febafce87612c4d232e6812ac | |
parent | 164e5bb5a74763f76e7b5315fe336d35d820466f [diff] |
Revert "Reland "Disable the popup for manual elevation in the recovery component."" This reverts commit a5c44bb1f8e6143e48cb27a0f7c04ff992cfdae9. Reason for revert: Still failing compile on builds as seen here - https://ci.chromium.org/ui/p/chrome/builders/ci/mac64/55586/overview More errors for unused function 'ReadManifest' and 'WaitForElevatedInstallToComplete' Original change's description: > Reland "Disable the popup for manual elevation in the recovery component." > > This is a reland of commit 63726cc221f38bd51c0945b87e2e115d9fcc02d5 > > The original patchset is 1. In addition, this removes fixes > `unused function 'ElevatedInstallRecoveryComponent' [-Werror,-Wunused-function]` > which broke the original CL. > > Bug: 1309203 > > Original change's description: > > Disable the popup for manual elevation in the recovery component. > > > > This CL disables showing the popup and triggering the elevated > > execution of the recovery process. > > > > The legacy recovery component is not being used in Windows anymore. > > However, there is an execution path which runs parts of this code, and > > has resulted in crashes, such as: crbug.com/1304125 > > > > Bug: 1309203 > > Change-Id: I617d1e12bb47cb2947957e2df14d360dfe8bac8e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3541602 > > Reviewed-by: Xiaoling Bao <xiaolingbao@chromium.org> > > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > > Reviewed-by: Peter Kasting <pkasting@chromium.org> > > Commit-Queue: Peter Kasting <pkasting@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#984023} > > Bug: 1309203 > Change-Id: Ifa31976b8932a736014f8e86b0f7c2481e5eb204 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3543890 > Reviewed-by: Xiaoling Bao <xiaolingbao@chromium.org> > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Commit-Queue: Sorin Jianu <sorin@chromium.org> > Cr-Commit-Position: refs/heads/main@{#984441} Bug: 1309203 Change-Id: Ie7c747435505f3c4569c754a8a50ea1352e33438 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3546711 Auto-Submit: Tim Judkins <tjudkins@google.com> Reviewed-by: Peter Kasting <pkasting@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Tim Judkins <tjudkins@google.com> Commit-Queue: Tim Judkins <tjudkins@google.com> Cr-Commit-Position: refs/heads/main@{#984497}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.