Google Git
Sign in
chromium / chromium / src / 9f9d26b3e9bbea49c89d8546e515d5261258a40c
commit9f9d26b3e9bbea49c89d8546e515d5261258a40c[log] [tgz]
authorMohamed Amir Yosef <mamir@chromium.org>Thu Feb 09 21:58:30 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Feb 09 21:58:30 2023
tree77c6fcea313043d006f835fd3c8d6bb1b5c5b46b
parent6d77e9d62e39e83d1d5cac4457748c9214759934 [diff]
[Passwords] Support Inline Username Editing from Password Details Bubble

This CL introduces the functionality of inline editing of usernames in
the password details bubble when the username is empty.

It works by introducing two rows in the details view: one for displaying
the empty username place holder (which is visible by default),
and another for editing the username (which is hidden by default).
Switching between edit and display modes works by hiding and showing
such rows accordingly.

Mocks: http://docs/presentation/d/1wcAel6Z0LndWDV4jiGzRtuLnawIdW-mgdabrt8JDVlg?resourcekey=0-j3j8SeZl-eq-mrV2NPPQrg#slide=id.g1b92a23caee_2_7

Screencast: http://go/scrcast/NTIyNjk4NzQyNjY3NjczNnw3M2RkZDliOC03YQ

Bug: 1408790
Change-Id: I6e1e4fc82163706a2bfdc1b63060966e7f09270e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4237595
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1103512}
2 files changed
tree: 77c6fcea313043d006f835fd3c8d6bb1b5c5b46b
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.