Google Git
Sign in
chromium / chromium / src / 9fb5578e589533c982b07c7b0551da905f6331ac
commit9fb5578e589533c982b07c7b0551da905f6331ac[log] [tgz]
authorMarc Treib <treib@chromium.org>Mon Feb 07 09:53:43 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Feb 07 09:53:43 2022
tree3d088a9b5fee9e5a4437ba7ad152bd1f175f27d5
parent81eb20134fd1f9e0107f05a7fb6ae5bf54d83df3 [diff]
Leak warning: Fix IsSaved computation

Before this CL, CredentialLeakFlags::kPasswordSaved got set if there was
a saved password for the given URL and username, but independent of
whether the actual saved *password* matched the leaked one.
As a result, users sometimes saw a slightly-wrong version of the leak
warning (correctly stating that the just-used password is leaked, but
offering not-quite-correct options for what to do about it).

This CL adds a check that the submitted password matches the saved one.

Bug: 1294179
Change-Id: I57dae68ff8491792446942226fd78deabde5f5ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3439872
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/main@{#967721}
1 file changed
tree: 3d088a9b5fee9e5a4437ba7ad152bd1f175f27d5
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.