commit | 9fc220892b3a5aa51312c9fad4ed2c93e4c6970c | [log] [tgz] |
---|---|---|
author | Daniel Andersson <dandersson@chromium.org> | Mon May 16 20:08:39 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon May 16 20:08:39 2022 |
tree | 27ede2404e440881301e92d4a3882c351714a313 | |
parent | d60f7bf318fd7b67f6ebd99175b4726cf8cb9838 [diff] |
saved_desks: Minor cleanups in SavedDeskItemView. * Make `desk_template` return by const reference instead of pointer since the value is always going to be there. * Have `uuid` return by const ref instead of by value. The previous implementation was likely returning by value because of the underlying accessor in `DeskTemplate` which was also returning by value. * Have `DeskItemGridView` use the existing `uuid` function instead of `item->desk_template().uuid()`. * Make the constructor take a `unique_ptr<DeskTemplate>` to make it obvious that it is taking over ownership. * `SavedDeskIconContainer` doesn't need non-const access to the template. Change-Id: I333807e1304eea915b686e5cdea2210da0023bbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3646807 Commit-Queue: Daniel Andersson <dandersson@chromium.org> Reviewed-by: Yongshun Liu <yongshun@chromium.org> Cr-Commit-Position: refs/heads/main@{#1003897}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.