Fix partial-damage rasterization in SyncConfirmationUIDialogPixelTest

`sync-confirmation-app-refresh` uses
`shared_gradient_light_background.svg` as a full-viewport background
image (`<feGaussianBlur stdDeviation="66.5"/>`). During
`SyncConfirmationUIDialogPixelTest::ShowUi`, the dialog initializes and
displays in `ScreenMode.PENDING` (`#confirmButton` and `#notNowButton`
hidden with `.visibility-hidden`) before the asynchronous
`'screen-mode-changed'` WebUI event arrives, and `DisplayModal()`
focuses the WebContents so `#confirmButton[autofocus]` draws its 4px
focus ring before `TestBrowserUi::VerifyPixelUi` clears focus.

Because `VerifyPixelUi` only waits on the browser UI compositor and not
the renderer compositor, if either the button row visibility update or
focus ring removal is rasterized in a subsequent renderer frame after
an initial full frame, Skia clips `<feGaussianBlur>` evaluation to the
partial damage rect (`.action-row.dialog` or its union with
`#confirmButton`'s 4px outline), shifting background pixels inside that
rect by 1-2 RGB values and exceeding the fuzzy pixel diff threshold.

Clear focus on the dialog widget before waiting on the renderer, wait
for the WebUI element to exit `ScreenMode.PENDING`, and force a
full-viewport repaint before `ShowUi` returns.

Bug: 576742061
Change-Id: I1725ffef13985bcac0189e6c587eba0d5cb58e3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8640753
Auto-Submit: Russ Hamilton <behamilton@google.com>
Reviewed-by: Dana Fried <dfried@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1726170}
1 file changed
tree: 99c63c32c620f55c597152956a056abe7709a4f1
  1. .agents/
  2. .claude/
  3. .gemini/
  4. .github/
  5. agents/
  6. android_webview/
  7. apps/
  8. ash/
  9. base/
  10. build/
  11. build_overrides/
  12. buildtools/
  13. cc/
  14. chrome/
  15. chromecast/
  16. chromeos/
  17. codelabs/
  18. components/
  19. content/
  20. crypto/
  21. dbus/
  22. device/
  23. docs/
  24. extensions/
  25. fuchsia_web/
  26. gin/
  27. google_apis/
  28. gpu/
  29. headless/
  30. infra/
  31. ios/
  32. ipc/
  33. media/
  34. mojo/
  35. net/
  36. pdf/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webkit/
  52. .clang-format
  53. .clang-tidy
  54. .clangd
  55. .cursorignore
  56. .geminiignore
  57. .git-blame-ignore-revs
  58. .gitallowed
  59. .gitattributes
  60. .gitignore
  61. .gitmodules
  62. .gn
  63. .mailmap
  64. .rustfmt.toml
  65. .yapfignore
  66. ATL_OWNERS
  67. AUTHORS
  68. BRANCH_FEATURE_OWNERS
  69. BRANCH_OWNERS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. package.json
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. SECURITY_OWNERS
  86. vpython.toml
  87. vpython.toml.uv.lock
  88. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.