Google Git
Sign in
chromium / chromium / src / a011ba15be38e2212401850b3a5262adae67b7b2
commita011ba15be38e2212401850b3a5262adae67b7b2[log] [tgz]
authorandrewxu <andrewxu@chromium.org>Tue Jan 14 17:50:31 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Jan 14 17:50:31 2025
tree54716a173c882c50ed8a8f43ec73b53271401534
parent056ae2d53c72a1b28c1c77a2f8e38d79bfd23025 [diff]
Fix the excessive menu close triggered by PreTargetHandler

chromeos::editor_menu::PreTargetHandler by default closes the active
context menu if any, when PreTargetHandler is destroyed.

This behavior causes the trouble if the PreTargetHandler closes the
wrong menu. It can happen, for example, when the PreTargetHandlerView
is destroyed due to the code path from OnMenuClosed(). OnMenuClosed()
can be triggered asyncly after executing a menu command that starts
a new menu. As a result, PreTargetHandler is destroyed after the
new menu shows and PreTargetHandler's destructor closes the new menu.

This CL serves as a quick fix by avoiding closing the active context
menu if the PreTargetHandlerView is reset due to menu close. In other
words, if the anchor menu is already closed, we avoid closing it twice.

Bug: 384726630
Change-Id: I7d426fa7eeabffa7b26e207c39211cfccd4875e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6142816
Reviewed-by: Andre Le <leandre@chromium.org>
Reviewed-by: Bao-Duy Tran <tranbaoduy@chromium.org>
Commit-Queue: Andrew Xu <andrewxu@google.com>
Reviewed-by: Chuong Ho <hdchuong@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1406177}
6 files changed
tree: 54716a173c882c50ed8a8f43ec73b53271401534
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.