[Reland] Element::VisibleBoundsInLocalRoot performs clipping

Reland Note: Reverted CL in first Patchset. It missed updating the
mac14-arm64 expectation.

VisibleBoundsRespectingClipsInLocalRoot was added in
https://crrev.com/c/6525508 as it was urgent but the real desire is for
VisibleBoundsInLocalRoot to have the overflow clipping behavior. This CL
makes the change to unify these two method behind a flag (as there may
be compat issues). Assuming this lands safely we can merge the two
methods.

VisibleBoundsInLocalRoot clips to ancestor frame rects but not to any
element clips (e.g. overflow:hidden). This change performs the entire
mapping using MapToVisualRectInAncestorSpace which does apply these
clips. The change is flag guarded in case of compatibility issues.

Making this change broke HTMLSelectElementTest.VisibleBoundsInLocalRoot
This is because MapToVisualRectInAncestorSpace causes the
subpixel-positioned rect to expand which can cause a select drop down to
appear detached from the element. This is why this function was using a
rounded absolute rect. This comes from https://crrev.com/1268243002. The
bug here appears to be coming from LayoutBox::ApplyBoxClips which
unnecessarily(?) snaps to pixels.

The spat-nav changes came from https://crrev.com/c/1243246 - the
IsOffscreen function no longer checks VisibleContentRect so only the
TODO is removed there stale test expectations can now be removed.
Technically SpatNav's NodeRectInRootFrame could now just be replaced by
VisibleBoundsInLocalRoot except that it has an edge-case for border
insets; its necessity is unclear.

Bug: 41417572,415110566
Change-Id: I5b8e7457731689d7721a15943f1d01508045cc1e
Include-Ci-Only-Tests: chromium.mac:mac14-arm64-rel-tests|blink_web_tests
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6617920
Reviewed-by: Philip Rogers <pdr@chromium.org>
Auto-Submit: David Bokan <bokan@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1469624}
10 files changed
tree: a02b75b0a5898371b72e8360cba29ce91e0be5b9
  1. .github/
  2. android_webview/
  3. apps/
  4. ash/
  5. base/
  6. build/
  7. build_overrides/
  8. buildtools/
  9. cc/
  10. chrome/
  11. chromecast/
  12. chromeos/
  13. codelabs/
  14. components/
  15. content/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. .clang-format
  51. .clang-tidy
  52. .clangd
  53. .git-blame-ignore-revs
  54. .gitallowed
  55. .gitattributes
  56. .gitignore
  57. .gitmodules
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython3
  62. .yapfignore
  63. ATL_OWNERS
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. CPPLINT.cfg
  69. CRYPTO_OWNERS
  70. DEPS
  71. DIR_METADATA
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. SECURITY_OWNERS
  80. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.