| commit | a028adb10584a3df243a3edb4a2357d072c42d6a | [log] [tgz] |
|---|---|---|
| author | Junji Watanabe <jwata@google.com> | Fri Jun 14 06:59:35 2024 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Jun 14 06:59:35 2024 |
| tree | 9debe54669a972825044fb129f08ab6829823ab5 | |
| parent | 188c5c7fd3e6466364d8fc6d609fcf1e9c3b71af [diff] |
build: Add missing dep //chrome/browser:lcp_critical_path_predictor_proto to //chrome/browser/ui:ui
This fixes the following build error.
FAILED: a0e913f7-1690-4324-b3af-55ac95e99dbe "./obj/chrome/browser/ui/ui/chrome_omnibox_client.o" CXX obj/chrome/browser/ui/ui/chrome_omnibox_client.o
stderr:
In file included from ../../chrome/browser/ui/omnibox/chrome_omnibox_client.cc:34:
In file included from ../../chrome/browser/predictors/loading_predictor.h:20:
In file included from ../../chrome/browser/predictors/preconnect_manager.h:20:
In file included from ../../chrome/browser/predictors/resource_prefetch_predictor.h:23:
../../chrome/browser/predictors/lcp_critical_path_predictor/lcp_critical_path_predictor_util.h:10:10: fatal error: 'chrome/browser/predictors/lcp_critical_path_predictor/lcp_critical_path_predictor.pb.h' file not found
10 | #include "chrome/browser/predictors/lcp_critical_path_predictor/lcp_critical_path_predictor.pb.h"
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Bug: 345654220
Fixed: 345654220
Change-Id: I2ca88ef76479226f3898e4c6c2613f9a82c7cf6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5632918
Commit-Queue: Junji Watanabe <jwata@google.com>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
Auto-Submit: Junji Watanabe <jwata@google.com>
Cr-Commit-Position: refs/heads/main@{#1315061}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.