Google Git
Sign in
chromium / chromium / src / a032e85f49c7d43cab4307ec4a1f9f8f6f608ff6
commita032e85f49c7d43cab4307ec4a1f9f8f6f608ff6[log] [tgz]
authorRohit Bhatia <bhatiarohit@google.com>Fri Sep 02 00:01:50 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Sep 02 00:01:50 2022
treece4523ef71ca286beae486a2c2174619cd35cf02
parentcd81f4372bd54919356af90ebdc2f46fa1fdb076 [diff]
[DownloadBubble] Open history loaded pdfs in Chrome

Downloads loaded from history service do not have
should_prefer_opening_in_browser_ set. This CL sets that field for
downloads lazily, i.e when used. This happens when the context menu is
being created or when downloads are being opened.

Call DetermineIfHandledSafelyHelper synchronously from DownloadItemModel::ShouldPreferOpeningInBrowser as
the callers for download opening and context menu creation expect the
response synchronously.

Enable the change only under DownloadBubbleV2, to allow for
experimentation for effect.

Screencasts
With fix: http://go/scrcast/NjQzNDAzMzM4Mzc2ODA2NHw4ZTA4YzM1Ny0xYg
Without fix: http://go/scrcast/NTcyNjc2NTMxNDk5ODI3Mnw1MGJhNjU2ZS1kNQ

Bug: 1352120
Change-Id: I9275b78920c9874c49d7570a83e49e5b42ca03b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3852182
Commit-Queue: Rohit Bhatia <bhatiarohit@google.com>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1042374}
10 files changed
tree: ce4523ef71ca286beae486a2c2174619cd35cf02
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.