Google Git
Sign in
chromium / chromium / src / a03a9db8957ddd5c52fd80464e3c1b39b1b70999
commita03a9db8957ddd5c52fd80464e3c1b39b1b70999[log] [tgz]
authorDavid Bokan <bokan@chromium.org>Tue May 09 12:39:27 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue May 09 12:39:27 2023
tree8a545648b0ea2f59f14ddfe7304ad6ead2cb5f1f
parent6fed3bb1cf3540eba7e285a59574d30ac5614ead [diff]
Fix flaky PasswordProtection test

This de-flakes the DeferActivatePrerenderStartedAfterRequest test. This
test would occasionally fail as the PasswordProtectionRequest issues a
real request using the SimpleURLLoader. These browser tests expect that
a request won't receive a response (in time?) and mock responses by
manually calling FinishRequest. However, in the flaky runs the URLLoader
receives a real response before the test's mock response and this causes
the CommitDeferringCondition to be destroyed unexpectedly.

This CL adds a bit to PasswordProtectionRequest that allows skipping the
URLLoader request from tests.

Bug: 1433599
Change-Id: Id57f308f114043e321f54a57f9854145dbd56ec5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4509446
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Xinghui Lu <xinghuilu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1141309}
7 files changed
tree: 8a545648b0ea2f59f14ddfe7304ad6ead2cb5f1f
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.