Google Git
Sign in
chromium / chromium / src / a08c78bcc5aee86d74174ee1e1925d4fe003f67a
commita08c78bcc5aee86d74174ee1e1925d4fe003f67a[log] [tgz]
authorJoey Arhar <jarhar@chromium.org>Sat Jun 01 01:44:59 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Sat Jun 01 01:44:59 2024
treea10e13d469dc08a4fd9627021d1ab95098a209e4
parentec178d46e71ea8cf32376141d4b08dc89ee5a0fc [diff]
Make showPicker() consume user activation

Allowing the page to call showPicker() on select elements as much as it
wants without consuming user activation may result in the user being
unable to interact with the browser UI due to popups always taking
focus.

The HTML spec also says to do this for input elements, so I added code
to do it there as well.

This patch also modified the select showPicker test because calling
showPicker on a select twice in a row in the test somehow resulted in
blink not seeing any input events on the second test_driver.bless(),
perhaps because the select's popup is still open and is somehow
intercepting the input.

HTML spec: https://github.com/whatwg/html/pull/10344

Bug: 1521345
Fixed: 343302069, 343093082, 343473478
Change-Id: If6308a67bac9050f695d18d275ea86c23ac22b0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5235516
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Di Zhang <dizhangg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1309009}
16 files changed
tree: a10e13d469dc08a4fd9627021d1ab95098a209e4
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.