Google Git
Sign in
chromium / chromium / src / a0921a2895ac0e8ccaf576a70452a9252ac949f0
commita0921a2895ac0e8ccaf576a70452a9252ac949f0[log] [tgz]
authorMiguel Casas <mcasas@chromium.org>Mon May 15 22:01:32 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon May 15 22:01:32 2023
tree886902c323a1c74fdba05038f12a1e6ff30b7b65
parentfdc67e52d852893c25d57674a0c1cc0eff983260 [diff]
media/gpu/v4l2: Fold GenericV4L2Device into V4L2Device

This CL folds GenericV4L2Device into V4L2Device since the former is
the only derived class of V4L2Device, which is itself far from
abstract.

For that the CL removes the pure abstract methods, copying the
bodies into an approximate good location in the .cc file -- only
approximate because the method definitions don't follow their
declaration order and I didn't want to muddy git history too much.

The history of the moved code will likely be lost though; looking
at the implementation it looks simple enough to me that there
shouldn't be questions about it that need going back in history to
answer.

No new functionality intended, only moving code around. In particular
the method bodies are copied verbatim.

Bug: b:279980150
Change-Id: Ieed25b3a3849b50ea8db119936c32ccb0cff7e72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4529356
Reviewed-by: Steve Cho <stevecho@chromium.org>
Commit-Queue: Miguel Casas-Sanchez <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1144408}
5 files changed
tree: 886902c323a1c74fdba05038f12a1e6ff30b7b65
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.