Google Git
Sign in
chromium / chromium / src / a096d56ebdcb1608d4fec5921cbb7da84ae445b2
commita096d56ebdcb1608d4fec5921cbb7da84ae445b2[log] [tgz]
authorAnders Hartvoll Ruud <andruud@chromium.org>Mon Aug 24 20:12:57 2020
committerCommit Bot <commit-bot@chromium.org>Mon Aug 24 20:12:57 2020
treed02a86b05b64461ec881c25840bff7be5e657c90
parent7f2f1978b22f1bbc3bb48d35fecb6407d6617691 [diff]
Remove Style[Non]InheritedVariables::needs_resolution_

Before StyleCascade, we used to store CSSVariableData objects in need
of var()-resolution on ComputedStyle, and the resolve those
CSSVariableData objects "in place". There was also a performance
optimization which utilized flags which told us whether or not there
was any CSSVariableData object in need of resolution somewhere in
Style[Non]InheritedVariables.

The flags can now be removed, since all CSSVariableData objects are
now resolved in StyleCascade _before_ storage on ComputedStyle.

Change-Id: Ia176691bb02f6da4e3eb322b4984acf707654e4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372143
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801121}
3 files changed
tree: d02a86b05b64461ec881c25840bff7be5e657c90
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.