Google Git
Sign in
chromium / chromium / src / a0c30f648d149d146b3dfad2642c723e5297ec8f
commita0c30f648d149d146b3dfad2642c723e5297ec8f[log] [tgz]
authorJocelyn Tran <jocelyntran@google.com>Wed Jul 24 16:43:00 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jul 24 16:43:00 2024
tree47cdc87ee85dffd9c5265f8410118a0e416a7199
parent1809e75aa05a0dd568404e4948ac0d5c05847edd [diff]
Reland "[A11y] Mark node(s) dirty when language changes"

This is a reland of commit e7338f6a238a12e698450ed3499a7666053d1413

The original change marked the root node dirty by using
AXObjectCacheImpl::Root(). Root() tries to create a root node if it
doesn't already exist, however, it is not possible to create a root node
in certain lifecycle stages (see b/354475210).

This CL uses document_ to reference the root instead. If the root does
not exist, a root node will not be created.

Original change's description:
> [A11y] Mark node(s) dirty when language changes
>
> Previously, if the lang attribute on the <html> element changed, the
> <html> node and the root node of the accessibility tree did not update
> with the new language.
>
> This change marks an element dirty if its language attribute changes so
> that the proper nodes in the accessibility tree are updated with the new
> language.
>
> Fixed: 352665692
> Change-Id: I4fc0a9c3f912dc4858c22e761fb13d655c2dc0cf
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5719426
> Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
> Commit-Queue: Jocelyn Tran <jocelyntran@google.com>
> Cr-Commit-Position: refs/heads/main@{#1330599}

Change-Id: I2fd62fe13b3390c8590c63ccf2d6e345644d296b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5730137
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1332397}
6 files changed
tree: 47cdc87ee85dffd9c5265f8410118a0e416a7199
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.