commit | a0c5e79e8918e1b97a0f91063b7159c6db8052ab | [log] [tgz] |
---|---|---|
author | Yao Xiao <yaoxia@chromium.org> | Mon May 16 20:43:07 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon May 16 20:43:07 2022 |
tree | ede04f7b5ab1c544f0e6e994752385bdfaa05862 | |
parent | 3e96ad8ab7b3cce59622456376393cd0a86b9712 [diff] |
[Topics] topics-internals: display a warning on invalid classifier input What: In the "Classifier" tab, display a warning if the input string has a '/' in it. Why: the user may attempt to type full URLs, but the classifier is only expecting hostnames. The result topics can appear to be wrong due to the misuse and misunderstanding. See https://crbug.com/1325402#c1 for screenshots. (cherry picked from commit 747b6d32b7f31aac87775aa8f4fd2ea8fe976b70) Bug: 1325402 Change-Id: If3bed831d14c54531b872bef04d05f000ddbec03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3647724 Reviewed-by: Josh Karlin <jkarlin@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1003269} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3649945 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yao Xiao <yaoxia@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5060@{#31} Cr-Branched-From: b83393d0f4038aeaf67f970a024d8101df7348d1-refs/heads/main@{#1002911}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.