commit a11f636a2b4345d5004edabf6605e2540c8be24f
author Hiroki Sato <hirokisato@google.com> Fri Feb 21 02:17:28 2020
committer Commit Bot <commit-bot@chromium.org> Fri Feb 21 02:17:28 2020
tree 99d8221299d484d2e1080ca58656aba0b93d732a
parent 6bd49e8af58b6dfccbcb85ea88efccb5eba444eb

Fix ARC a11y bounds computation

AXRelativeBounds assumes that the bounds are relative to the root of the
tree by default, but in ARC, every nodes' bounds are computed relative
to its container.

AutomationInternalCustomBindings::ComputeGlobalNodeBounds computes the
bounds by first calling AXTree::RelativeToTreeBoundsInternal to compute
the node's relative bounds to its root using AXRelativeBounds, and then
applying the difference between the root and the container.

In Dialog or Popup window, the root node can have some amount of offset
to its container. As a result, every computed bounds in such window
has "doubled" offset to ARC container.

This CL fixes the computation.

This CL also simplifies geometry_util in arc a11y because
exo::WMHelper::GetInstance() never returns nullptr.

Bug: b:145260260
Test: manual. With TalkBack-test app, Alerts window has correct bounds.
Change-Id: I93033ad0b2771828cdf00d17d1ebe039ef1d7044
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061930
Commit-Queue: Hiroki Sato <hirokisato@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743386}