Google Git
Sign in
chromium / chromium / src / a120a5bef6e554deffbad6f2d5909631a5a695a3
commita120a5bef6e554deffbad6f2d5909631a5a695a3[log] [tgz]
authorBenjamin Beaudry <benjamin.beaudry@microsoft.com>Fri Mar 29 01:32:25 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Mar 29 01:32:25 2024
tree1b3bc3eec7d70d97c1ab8e15ab2f40ea6ca53659
parentccbfea8ffe76432b9fe60bec05bfec8e5685e55a [diff]
[UIA] Fix live regions on Views when UIA is enabled

Enabling UIA in Chromium led NVDA to stop announcing some live region
events when fired from Views. Narrator was also unable to announce them.

This was caused by a bug in the new-ish announcement mechanism
introduced in CL:4986151. While this change is a net improvement to the
accessibility platform for Views, on UIA, the live regions were being
fired by a node that was not exposed in the UIA control tree. The
control tree is what ATs look at to find where the live region event is
coming from, so it's crucial that all nodes firing live regions are
part of that tree.

This CL fixes this issue, and adds a test to prevent future regressions.

Fixed: 330806089
Change-Id: I9a2d83e80d4078ec45872f3cd90176723a5865e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5404780
Reviewed-by: Jacques Newman <janewman@microsoft.com>
Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1280031}
2 files changed
tree: 1b3bc3eec7d70d97c1ab8e15ab2f40ea6ca53659
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.