commit a14249929f2074f94643269e4e121c1c69359a13
author Shakti Sahu <shaktisahu@chromium.org> Thu Oct 31 22:54:08 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Oct 31 22:54:08 2024
tree 0572888af163430604db7d8170d708b6c8f2a39b
parent f7e6336a816a2affbf41140f5efed13622408ef0

[TG Sync] Identify sync initiated navigation using NavigationUiData

A navigation in response to a sync message is always filtered out
from sending back to sync in order to avoid ping pong issues.
Currently these sync initiated navigations are identified by
explicitly keeping the NavigationHandle pointer in
SavedTabGroupWebContentsListener.
This is cumbersome and requires a plumbing between the callsites
for LoadURL and the observer method DidFinishNavigation which is very
easy to miss.
This CL improves that by introducing a boolean in the NavigationHandle's
custom data (ChromeNavigationUiData). By setting this boolean
correctly and checking on the observer event, we get rid of the problem
of plumbing/managing NavigationHandles.
The boolean can be set at the NavigateParams (chrome layer) during
loading a URL which is then subsequently passed to NavigationUIData and
thereby being accessible from NavigationHandle.

Notes:
1. Manual testing - Manually verified three cases that this works
a. Navigating a tab on remote computer
b. Adding a new tab on remote computer
c. Opening a tab group from bookmarks bar
d. Navigating a local tab
e. Adding a local tab
f. Restarting chrome with the group/tab open

2. There is still plumbing of NavigationHandle pointers from several
callsites to the SavedTabGroupWebContentsListener class which isn't
required any more. Those will be removed soon in a follow-up CL.

3. This is still desktop only. As part of future work,
we aim to extend this support for android which requires a bit more plumbing and serialization to/from WebContentsState byte buffer.

Bug: 359982911
Change-Id: Ife9412122760a59893208275fdaf8cac78054f52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5980260
Reviewed-by: David Pennington <dpenning@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Darryl James <dljames@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1376652}