commit a18d146293a6019fb6577107dbfb1955d38f24e5
author Colin Blundell <blundell@chromium.org> Fri Jun 18 08:57:31 2021
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Jun 18 08:57:31 2021
tree ad7c99361c271011490e63504d40259ad35025b6
parent 4d594cf797e428be29ded273e42aea544b475e1c

[SafeBrowsing] Remove thread_utils.h from V4Database

thread_utils.h is a utility that allows //components/safe_browsing/core
to use //content's and //ios/web's threading primitives via different
implementations that are conditionally included in the GN target. We
are going to eliminate this utility as part of eliminating
//components/safe_browsing/core's incorrect dependences on
//components/safe_browsing/{content, ios}.

This CL removes usage of thread_utils.h in
//components/safe_browsing/core's V4Database. This class executes
on the DB and IO thread and uses thread_utils.h to verify that certain
methods are called on the IO thread. We replace those DCHECKs with
usage of a ThreadChecker. However, it is slightly tricky to do so as
the object is created on the DB thread and never explicitly told which
thread is the IO thread. To handle this, we add a
V4Database::InitializeOnIOThread() method that the client is responsible
for invoking on the IO thread.

Bug: 1216341
Change-Id: I439d90eb8a0bdaf74f918471b0976b639c2cec6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2966500
Reviewed-by: Xinghui Lu <xinghuilu@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#893746}