commit a18d9f4284fb6600b11459d1f31c05ff71679e32
author Stefano Duo <stefanoduo@google.com> Fri Sep 08 13:21:41 2023
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Sep 08 13:21:41 2023
tree df66c2296cb8cb63d4fa9216dd5bdd11e386b089
parent af3de1027ccb5e04b54617a1a9c57e5bd0142df2

Add netlog calls to UDPClientSocket

* Make UDPClientSocket an actual netlog source
* Track its lifetime through SOCKET_ALIVE
* Track calls to Open/Connect/BindToNetwork

This was useful to figure out why connection migration was failing in
a yet-to-merge integration tests. The probing socket BindToNetwork
call was failing due to a missing permission.

# Connection migration failing example
## Before
Source type:QUIC_SESSION, Description: test.example.com, Entry:
[...]
t= 36 [st=31]    QUIC_SESSION_NETWORK_MADE_DEFAULT
                 --> new_default_network = 432902426637
t= 36 [st=31]    QUIC_CONNECTION_MIGRATION_ON_NETWORK_MADE_DEFAULT
                 --> new_default_network = 432902426637
t= 37 [st=32]    QUIC_CONNECTION_MIGRATION_ON_MIGRATE_BACK
                 --> retry_count = 0
t= 37 [st=32]    QUIC_CONNECTION_MIGRATION_FAILURE
                 --> connection_id = "5eaf24f6fb345513"
                 --> reason = "Socket configuration failed"
Source type:UDP_SOCKET, Description: None, Entry:
t=37 [st=0]  SOCKET_ALIVE  [dt=0]
             --> source_dependency = 13 (QUIC_SESSION)

## After
Source type:QUIC_SESSION, Description: test.example.com, Entry:
[...]
t= 36 [st=31]    QUIC_SESSION_NETWORK_MADE_DEFAULT
                 --> new_default_network = 432902426637
t= 36 [st=31]    QUIC_CONNECTION_MIGRATION_ON_NETWORK_MADE_DEFAULT
                 --> new_default_network = 432902426637
t= 37 [st=32]    QUIC_CONNECTION_MIGRATION_ON_MIGRATE_BACK
                 --> retry_count = 0
t= 37 [st=32]    QUIC_CONNECTION_MIGRATION_FAILURE
                 --> connection_id = "5eaf24f6fb345513"
                 --> reason = "Socket configuration failed"
Source type:UDP_CLIENT_SOCKET, Description: None, Entry:
t=42 [st=0] +SOCKET_ALIVE  [dt=2]
             --> source_dependency = 16 (QUIC_SESSION)
t=42 [st=0]    SOCKET_OPEN
t=43 [st=1]    SOCKET_BIND_TO_NETWORK
               --> net_error = -10 (ERR_ACCESS_DENIED)
               --> network = -889270259
t=44 [st=2] -SOCKET_ALIVE
Source type:UDP_SOCKET, Description: None, Entry:
t=42 [st=0]  SOCKET_ALIVE  [dt=2]
             --> source_dependency = 22 (UDP_CLIENT_SOCKET)

Bug: b:290583020
Change-Id: Ia3e5e52c966dafea5bd0f4d27c4e936a1abeb361
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4839443
Commit-Queue: Stefano Duo <stefanoduo@google.com>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1194061}