Google Git
Sign in
chromium / chromium / src / a19539acc4eca806aca1f02bfd82735de038a65b
commita19539acc4eca806aca1f02bfd82735de038a65b[log] [tgz]
authorNikhil Nayunigari <nikhilcn@google.com>Tue Apr 30 04:24:11 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Apr 30 04:24:11 2024
tree486b25c4612380aee7340154a3efbe79b476e486
parent33d1be1987c5532ee0253c01dd71541c8787cf74 [diff]
[CrOS Hotspot] Fix inconsistencies in hotspot metrics

When hotspot is disabled due to user actions, we record metrics multiple
times: one from hotspot controller and other from state changes in
hotspot state handler. While hotspot controller records accurate reason
such as 'wifi_enabled' etc, we get a generic reason from hotspot state
handler such as 'user_initiated'.

With these changes, we are ignoring 'user_initiated' disable reason
being sent from hotspot_state_handler as all user initiated reasons
should be recorded from hotspot_controller.

(cherry picked from commit f9e5ac3e4b31f530f9d43d06c5b62834f773ed42)

Bug: b/333082297
Change-Id: I5b9cffc7f651c05b229e646b8802d13ded689de1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5486744
Commit-Queue: Nikhil Nayunigari <nikhilcn@google.com>
Reviewed-by: Jason Zhang <jiajunz@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1292552}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5499210
Cr-Commit-Position: refs/branch-heads/6422@{#495}
Cr-Branched-From: 9012208d0ce02e0cf0adb9b62558627c356f3278-refs/heads/main@{#1287751}
3 files changed
tree: 486b25c4612380aee7340154a3efbe79b476e486
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.