[gardener] Revert "Set app container ACLs reliably on out directory" This reverts commit 0170d6e8fcbe8a75e91889824825f118dc71044a. Reason for revert: Consistent builder failures caused by this CL: https://ci.chromium.org/ui/p/chromium/builders/ci/linux-win-cross-rel?limit=500 First failure: https://ci.chromium.org/ui/p/chromium/builders/ci/linux-win-cross-rel/3559/overview Original change's description: > Set app container ACLs reliably on out directory > > Sandbox on Windows relies on AppContainer sandbox for certain sandboxes. > The AppContainer sandbox requires that files loaded in those processes > have the right security attributes (ACLs), or they will not be allowed > to load. We can set the security attributes for a local build using the > icacls tool, which currently runs when //sandbox/win:sandbox target is > built, ensuring it happens as part of building chrome.dll. > > The APIs used for ACL-ing by icacls are subject to race conditions when > files are generated in the folder while it's running, as is the case > with a chromium build for binaries such as component build dlls and > chrome_elf.dll. > > This change resolves the race condition by ensuring the ACL-ing step > will happen via a DEPS of each executable target by default, which > should guarantee that icacls finishes running before we link any > binaries which require it. > > Bug: 379656387 > Change-Id: I454569d11eed36a657389711fdeaa1f9a61549e4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6068009 > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Commit-Queue: Stefan Smolen <ssmole@microsoft.com> > Cr-Commit-Position: refs/heads/main@{#1393264} Bug: 379656387 Change-Id: Id886ae8f3b827603e7ad91ac2757469ce708c938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6076173 Reviewed-by: Fahad Mansoor <fahadmansoor@google.com> Auto-Submit: Sergey Poromov <poromov@chromium.org> Owners-Override: Sergey Poromov <poromov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/main@{#1393607}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.