commit a1c9e687c8ce80fd9baad52cbf361755bf5a84f7
author Michael Cui <mlcui@google.com> Wed Apr 30 03:13:49 2025
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Apr 30 03:13:49 2025
tree 1937ecddff43ca77a94e71ce3b98dbca01919418
parent 631aef412ef5c4c0e0d2ed3febb550613b07f208

run_cargo: Fix `PATH`-lookup trouble by specifying `executable`

This CL is a partial revert of https://crrev.com/c/5377439.

In the aforementioned CL, `tools.clang.scripts.build.RunCommand` was
used instead of `subprocess.run`, as on Windows, the `PATH` environment
variable passed into `subprocess.run` was not used to look up the
executable provided in the command line.

A closer look at the `subprocess` documentation states that a fully
qualified path to the executable should be used for maximum reliability.
The Windows `CreateProcessW` documentation also mentions that the `PATH`
environment variable used to look up executable comes from the **current
process**.

Provide a fully qualified path instead as `executable` instead of using
`RunCommand`. This:
- ensures that Cargo sees itself being run as "cargo".
- removes the "Running [command]" and "Failed." print messages which are
  printed by `RunCommand`.
- removes the use of `shell=True`, preventing shell injections and
  allowing passing in path-like objects into the command line.

Bug: None
Change-Id: I6a6a2100d9b13507c6257f1ca9b46a41c379bf3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6326573
Commit-Queue: Michael Cui <mlcui@google.com>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1453690}