Revert "CrOS VCD: Enable auto-framing by default"
This reverts commit 05b4c15c9caae339cc1a4fe044df1081ac7bd7b6.
Reason for revert: I suspect this CL causes failures
TrayAccessibilityLoginTestInstance/TrayAccessibilityLoginTest.ShowMenuWithShowOnLoginScreen/1
SystemTrayClientEnterpriseAccountTest.TrayEnterpriseManagedAccount
TrayAccessibilityLoginTestInstance/TrayAccessibilityLoginTest.ShowMenuWithShowOnLoginScreen/0
SystemTrayClientEnterpriseAccountTest.TrayEnterpriseUnmanagedAccount
...2 more failure(s) (6 total)...
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/29843/overview
Original change's description:
> CrOS VCD: Enable auto-framing by default
>
> Make chrome://flags#auto-framing-override flag defaults to enabled. Note
> that the feature is still guarded by per-device feature profile.
>
> Bug: b:210929757, b:221980963
> Test: Toggle chrome://flags#auto-framing-override and check behavior.
> Change-Id: I6b477be98dc75336cce2fd3841dc2d0d487dc7d9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832988
> Auto-Submit: Ren-Pei Zeng <kamesan@chromium.org>
> Reviewed-by: Shik Chen <shik@chromium.org>
> Commit-Queue: Ren-Pei Zeng <kamesan@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1035455}
Bug: b:210929757, b:221980963
Change-Id: I2aa286a9de951259247cd636ecb8aa72e2e08b64
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834442
Owners-Override: Maxim Kolosovskiy <kolos@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Osama Fathy <osamafathy@google.com>
Reviewed-by: Osama Fathy <osamafathy@google.com>
Cr-Commit-Position: refs/heads/main@{#1035541}
diff --git a/media/capture/video/chromeos/video_capture_features_chromeos.cc b/media/capture/video/chromeos/video_capture_features_chromeos.cc
index 319016b..1d0ec3d 100644
--- a/media/capture/video/chromeos/video_capture_features_chromeos.cc
+++ b/media/capture/video/chromeos/video_capture_features_chromeos.cc
@@ -32,7 +32,7 @@
// TODO(pihsun): Migrate the flag to use base::Feature.
std::string value =
command_line->GetSwitchValueASCII(media::switches::kAutoFramingOverride);
- return value != media::switches::kAutoFramingForceDisabled;
+ return value == media::switches::kAutoFramingForceEnabled;
}
} // namespace media