Google Git
Sign in
chromium / chromium / src / a25e276beecef7b2f62bef5da4a2e4bca3fb546b
commita25e276beecef7b2f62bef5da4a2e4bca3fb546b[log] [tgz]
authorEmilia Paz <emiliapaz@chromium.org>Mon Mar 28 23:23:25 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Mar 28 23:23:25 2022
tree22aa17bb96c6bc59282486056a1ce00d5eaf1b3e
parent3358255ab8de25567ded99c6fc033ee69fde2136 [diff]
[Extensions c2s] Non-destructively update site access menu items

When an extension is updated, it may change site access and therefore
be on a different site access section.

Previously this is handled in two ways:
- When one site access item changed: update item, and then move between
sections if necessary
- When potentially many site access items changed: remove all site
access items, and insert in the correct section.

We can combine the update site access item and move to the correct
section into one method. This fixes two things:
- Risk of forgetting to "move items between sections if necessary"
after updating a site access item..
- Removing and re-adding all the views is a destructive operation that
can break things like current focus for a11y (crbug.com/1038821)

Bug: 1263310
Change-Id: Icf0f9e250556564f6313ee22731045897e12697c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3512478
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org>
Commit-Queue: Emilia Paz <emiliapaz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#986208}
2 files changed
tree: 22aa17bb96c6bc59282486056a1ce00d5eaf1b3e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.