Google Git
Sign in
chromium / chromium / src / a32debaa32f22fabcab1f4411e3a978c64355a19
commita32debaa32f22fabcab1f4411e3a978c64355a19[log] [tgz]
authorRyan Tarpine <rtarpine@chromium.org>Wed Sep 04 15:34:59 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Sep 04 15:34:59 2024
tree2304d8cc08ac392f08ea1848f0a38e27ed9f21cd
parent7bc7c14126a3c6de8cf8dd1c6cee73afcd9f696f [diff]
[DIPS] Migrate to ContentBrowserClient::IsFullCookieAccessAllowed().

Replace usage of CookieSettings::IsFullCookieAccessAllowed() with
ContentBrowserClient::IsFullCookieAccessAllowed().

Since ContentBrowserClient::IsFullCookieAccessAllowed() takes a
WebContents*, we can't call it from DIPSService, which is associated is
the BrowserContext as a whole. Instead, add an optional<bool> field to
DIPSRedirectInfo which is populated by RedirectChainDetector (which
knows its associated WebContents) before passing the redirects to the
DIPSService.

Many unit tests that call DIPSServiceImpl::HandleRedirect() or
HandleRedirectChain() had to be modified to set that field to make them
pass (the methods crash if the field is nullopt).

Bug: 358138963
Change-Id: I88169035f918c45e528a6fe5a4956752d22a3274
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5834290
Commit-Queue: Ryan Tarpine <rtarpine@chromium.org>
Reviewed-by: Anton Maliev <amaliev@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1350813}
7 files changed
tree: 2304d8cc08ac392f08ea1848f0a38e27ed9f21cd
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. internal
  52. ios_internal
  53. native_client
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .eslintrc.js
  60. .git-blame-ignore-revs
  61. .gitallowed
  62. .gitattributes
  63. .gitignore
  64. .gitmodules
  65. .gn
  66. .mailmap
  67. .rustfmt.toml
  68. .vpython3
  69. .yapfignore
  70. ATL_OWNERS
  71. AUTHORS
  72. BUILD.gn
  73. CODE_OF_CONDUCT.md
  74. codereview.settings
  75. CPPLINT.cfg
  76. CRYPTO_OWNERS
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.