Google Git
Sign in
chromium / chromium / src / a362e257655bf3690a17a4d25b1f8cb8e142f1b0
commita362e257655bf3690a17a4d25b1f8cb8e142f1b0[log] [tgz]
authorRoland Bock <rbock@google.com>Wed Apr 10 12:26:11 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Apr 10 12:26:11 2024
tree03a08a376886b35bd655b79f9c31a0b73253efe2
parentbeabc18587381e2261c7b107c3066a0f155670ef [diff]
Simplify invalidaton topic registration functions

This CL simplifies the code to update the topics an invalidator is
interested in:

- Duplication detection is now expressed very closely to the
  description.
- Dropping uninteresting topics is replaced simply with dropping all
  formerly interesting topics. This is much simpler and equivalent as we
  are always re-adding all interesting topics.
  The new code is also slightly more efficient as we need only one
  instance of ScopedDictPrefUpdate.

This CL is also a step towards replacing
  set<TopicData> with
  map<Topic, TopicMetadata>
as the new code will easily translate for the map.

Bug: b:333354294
Change-Id: I8087e64b33505aa4e0a9de5ca4ddc7352dcd373b
Tests: Existing unit tests
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5432176
Reviewed-by: Artem Sumaneev <asumaneev@google.com>
Commit-Queue: Roland Bock <rbock@google.com>
Cr-Commit-Position: refs/heads/main@{#1285062}
2 files changed
tree: 03a08a376886b35bd655b79f9c31a0b73253efe2
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.