commit | a39e2b8c3ccda06b8cea016c0c600b22865ad671 | [log] [tgz] |
---|---|---|
author | Victor Hugo Vianna Silva <victorvianna@google.com> | Thu Mar 27 19:58:03 2025 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Mar 27 19:58:03 2025 |
tree | e704fee29b2a2ea740f0ea6ba4e5c8bf6a381dc4 | |
parent | 61f85daac0024da71c3555f9119f1a4b3d66f4fa [diff] |
Improve comments in SessionsSyncUserState There was a TODO about updating this enum to "reflect the more modern product state machine". This probably got added because USER_SIGNED_IN_SYNC_OFF / USER_SIGNED_IN_SYNC_ON were interpreted as "signed-in with sync-the-feature off" / "signed-in with sync-the-feature on". In reality, looking at the implementation in [1], these refer to "tab sync off" / "tab sync on", which is still a valid distinction. So this CL leaves the enum as is and updates its documentation instead. [1] https://source.chromium.org/chromium/chromium/src/+/main:ios/chrome/browser/recent_tabs/ui_bundled/recent_tabs_mediator.mm;l=264-285;drc=260b80710982c3d47bddfe6b075a80a0ad6cd84a Fixed: 40276546 Change-Id: Id0932d387ef598f5659653c229d30f63399a064e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6400518 Auto-Submit: Victor Vianna <victorvianna@google.com> Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/main@{#1438941}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.