| commit | a39ec8827c089cbaf3f3e79550dd2714dc2d886e | [log] [tgz] |
|---|---|---|
| author | Fabian Sommer <fabiansommer@chromium.org> | Mon Mar 14 12:38:45 2022 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Mar 14 12:38:45 2022 |
| tree | a7f6265bce9a398504c4e292beffbcaa7d126564 | |
| parent | 2972f6de6a5f1323e19c213bb012c55424f6153a [diff] |
Migrate GetDeviceType()
Migrate all uses of GetDeviceType from ash/constants/devicetype.h to use
the recently introduced GetDeviceType in chromeos/constants/devicetype.h
instead.
Remove GetDeviceType() from ash/constants/devicetype.{h,cc}
A "// nogncheck" is required in local_device_info_util_linux.cc because
otherwise, gn would incorrectly detect a dependency cycle for lacros -
this is because gn can not process the C preprocessor flags and does not
realize that this include is ash-specific.
Bug: 1284585
Change-Id: I9ccebad88026fe42e69ba882896fac1996c6fa6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3477140
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Jan Krčál <jkrcal@chromium.org>
Commit-Queue: Fabian Sommer <fabiansommer@chromium.org>
Cr-Commit-Position: refs/heads/main@{#980521}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.