Google Git
Sign in
chromium / chromium / src / a3a424ef205113afefc6cb007cb7f60a1ba0309f
commita3a424ef205113afefc6cb007cb7f60a1ba0309f[log] [tgz]
authorAbigail Klein <abigailbklein@google.com>Wed Mar 02 02:04:13 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Mar 02 02:04:13 2022
treee22a0272fb00226d40fdcfa265059782699ef1d2
parent8110c879a5ae96dfbb7f7b49d5ed8cf30a2efa33 [diff]
[Live Caption] Pass a LanguageCode to OnSodaInstalled.

CL doing this for OnSodaError: crrev.com/c/3439172
CL doing this for OnSodaProgress: crrev.com/c/3447537
This work is to simplify SodaInstaller observers' language management.
Design doc: https://docs.google.com/document/d/1OphVFqRcFbqgZYRUp_K2bCkiHdsT4EwJLvAzInfp428/edit

The bulk of the change happens in SodaInstaller, SodaInstallerImpl, and
SodaInstallerImplChromeOS. The rest of the files are mainly parameter
and function name changes.

Bug: 1161569
Fix: 1266491
Change-Id: I331f57f97527938503e77c25a1f25246026548e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3405315
Reviewed-by: Evan Liu <evliu@google.com>
Reviewed-by: Amanda Deacon <amandadeacon@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Abigail Klein <abigailbklein@google.com>
Cr-Commit-Position: refs/heads/main@{#976505}
33 files changed
tree: e22a0272fb00226d40fdcfa265059782699ef1d2
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.