Google Git
Sign in
chromium / chromium / src / a3b2461d00ee32bccf829f9240566d08cf080e8f
commita3b2461d00ee32bccf829f9240566d08cf080e8f[log] [tgz]
authorEshwar Stalin <estalin@chromium.org>Sat Jan 25 01:15:50 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Sat Jan 25 01:15:50 2025
treef17bd21fd6596f81ccd519c6fddc842d5021858f
parent162f5d2956f140c7eae0747ad0148425e2cd6996 [diff]
Consolidating Submenu and Context menu implementations of Saved Tab Group recall UI

This is second part of the fix to Saved Tab Group recall UI to fix issue
with favicons not being show correctly. While we fixed this for the App
Menu's submenu for Saved Tab Groups, the context menu used a different
implementation. In order to fix this issue, deleting the DialogModel
based context menu implementation and instead using a single model for
both these implementations. The duplicate DialogModel implementation
makes things harder to maintain. This also addresses the default favicon
issue seen with the context menu.

Bug: 343279726
Change-Id: I773a4a444e3df5caf950447d02876172fe10f2a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6196850
Commit-Queue: Eshwar Stalin <estalin@chromium.org>
Reviewed-by: Darryl James <dljames@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1411236}
11 files changed
tree: f17bd21fd6596f81ccd519c6fddc842d5021858f
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. description
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.