Internal debug UIs: Change implementation of pages behind pref, non-iOS

Overriding CreateWebUIController() results in a mismatch in bindings
when the user toggles the pref in chrome://chrome-urls and then uses
forward/back navigation to return to a debug UI. This is because
forward/back navigation requires state restoration for debug WebUI
pages. The mismatch in bindings causes a crash.

This CL instead has ChromeContentBrowserClient rewrite any debug UI
URLs (still tracked via InternalWebUIConfig) to
chrome://debug-webuis-disabled?host=hostname, where hostname is the host
of the debug WebUI. The InternalDebugPagesDisabledUI is served from
chrome://debug-webuis-disabled instead of being served from the
debug UI URLs directly.

A script is added to the internal debug pages disabled UI that
redirects to the debug page if the disabled UI is served when the
InternalDebugPagesEnabled pref is set to true. This is so that
navigating back after enabling debug UIs in chrome://chrome-urls
will appear to work correctly. Navigating back to a previously
enabled UI after disabling the UIs in chrome://chrome-urls will still
serve the original UI; a solution to this issue is TBD, but it is
less likely to impact users.

Note that iOS did not use the same implementation of this pref since
WebUIConfig is not used on iOS. The iOS implementation is unaffected
by this change.

Bug: 404788318
Change-Id: I1a007ed466776235963aa35e08894cd1cf923b09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6551440
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Sarah Krakowiak <skrakowi@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1462452}
22 files changed
tree: 2e34138dfc791d2e89a0dab1d7e45aaae56c39ca
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. .clang-format
  50. .clang-tidy
  51. .clangd
  52. .git-blame-ignore-revs
  53. .gitallowed
  54. .gitattributes
  55. .gitignore
  56. .gitmodules
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. CPPLINT.cfg
  68. CRYPTO_OWNERS
  69. DEPS
  70. DIR_METADATA
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. SECURITY_OWNERS
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.