Google Git
Sign in
chromium / chromium / src / a4266a2adf0ee3aa55ba62154aa290da853d2fb8
commita4266a2adf0ee3aa55ba62154aa290da853d2fb8[log] [tgz]
authorKenichi Ishibashi <bashi@chromium.org>Thu Aug 15 10:01:29 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Aug 15 10:01:29 2024
tree51f4b15354caedc8d8a6db668b5078cabe36851c
parentb335877aa612291ed7f60b0a160b91dfd715e660 [diff]
HttpStreamPool: Make H2 session unavailable when H1 is required

There could be a case where we successfully created a SpdySession but
HttpNetworkTransaction retries the connection disabling HTTP/2 due to
some errors (e.g. restarting for auth). In this case, we should not
use the existing SpdySession. When HTTP/1.1 is required and a
SpdySession is found, HttpStreamPool should mark the session
unavailable.

This fixes HttpNetworkTransactionTest.NTLMOverHttp2 when HttpStreamPool
is used.

Bug: 346835898
Change-Id: I3381e124bf0c3dc7fb340c4b1dee820305cde8a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5782595
Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1342195}
7 files changed
tree: 51f4b15354caedc8d8a6db668b5078cabe36851c
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. CRYPTO_OWNERS
  78. DEPS
  79. DIR_METADATA
  80. LICENSE
  81. LICENSE.chromium_os
  82. OWNERS
  83. PRESUBMIT.py
  84. PRESUBMIT_test.py
  85. PRESUBMIT_test_mocks.py
  86. README.md
  87. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.