commit | a2c9d0a944b7aab058845d061e877104702534cf | [log] [tgz] |
---|---|---|
author | danakj <danakj@chromium.org> | Wed Jul 25 20:01:18 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Jul 25 20:01:18 2018 |
tree | 1bde33d3615fc2959e2c584919e242848c6bc3a7 | |
parent | 42ec5b3d10370d86089c296c3486c2c5eb3be572 [diff] |
Stop overriding methods from RenderWidget in RenderViewImpl For each method that overrides RenderWidget, move it to the RenderWidgetOwnerDelegate interface, and have RenderWidget invoke it from there. If the override did not always call back to the RenderWidget base class, have it return a bool (true = I handled it, false = you handle it) so RenderWidget knows if it should exit or not. If an override called up to the RenderWidget not at the start or end but in the middle of its body, then it is split into multiple pieces in the RenderWidgetOwnerDelegate interface so that RenderWidget can call each piece to maintain the same code ordering. OnMessageReceived still inherits from RenderWidget as it is meant to implement IPC::Listener, however it is still tied up with RenderWidget and handles some of the same messages. There should be no behaviour change from this CL. R=dgozman@chromium.org Bug: 419087 Change-Id: I0f401742dfb78f195f3d834e307794fe8daa890b Reviewed-on: https://chromium-review.googlesource.com/1142374 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by: Albert J. Wong <ajwong@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#578027}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .