Google Git
Sign in
chromium / chromium / src / a498c649422ebe5b7c766af89833f5a6aa05cb0a
commita498c649422ebe5b7c766af89833f5a6aa05cb0a[log] [tgz]
authorGabriel Charette <gab@chromium.org>Wed Jan 08 18:32:47 2020
committerCommit Bot <commit-bot@chromium.org>Wed Jan 08 18:32:47 2020
tree53190e09e2f4f05617c4548c5f9fa03c738133e9
parentd35a5b7293dfb7f46e4e41865bc1091df5dc3e34 [diff]
[base] Fix flakiness in MessagePumpLibeventTest.QuitWatcher

The TSAN log shows that the issue is that the test's WriteFDWrapper
is using the |pipefds_| on |io_thread_| unsynchronized with the main
thread closing the pipe from TearDown().

Joining the test's |io_thread_| solves the issue.

R=fdoray@chromium.org

Bug: 955440
Change-Id: Ifc4966518d2e6abce4d0a3cd8b301e3241a057f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990340
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729406}
1 file changed
tree: 53190e09e2f4f05617c4548c5f9fa03c738133e9
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. ENG_REVIEW_OWNERS
  68. LICENSE
  69. LICENSE.chromium_os
  70. OWNERS
  71. PRESUBMIT.py
  72. PRESUBMIT_test.py
  73. PRESUBMIT_test_mocks.py
  74. README.md
  75. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .