Google Git
Sign in
chromium / chromium / src / a4a252fa9eb140131f33e249f8a713058507e153
commita4a252fa9eb140131f33e249f8a713058507e153[log] [tgz]
authorMinoru Chikamune <chikamune@chromium.org>Mon Feb 17 09:13:31 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Feb 17 09:13:31 2025
tree13b78f20687438201294fa740b937d8dc655f02d
parentb5aed3c38b718be5d496f0566e7688ec921b14d7 [diff]
Deflake DeferSpeculativeRFHCreationTest.CreationNotDeferredForWebUI

The following test sometimes fails with navigation_request->state()
check because the test depends on the timing of the check. This CL adds
nav_manager.WaitForRequestStart() so that the test can be run
deterministically.

- DeferSpeculativeRFHCreationTest.CreationNotDeferredForWebUI

Failure example:
navigation_browsertest.cc(9328): Expected equality of these values:
  navigation_request->state()
    Which is: 3
  NavigationRequest::NavigationState::WAITING_FOR_RENDERER_RESPONSE
    Which is: 1

Run history:
https://ci.chromium.org/ui/test/chromium/ninja%3A%2F%2Fcontent%2Ftest%3Acontent_browsertests%2FDeferSpeculativeRFHCreationTest.CreationNotDeferredForWebUI

This CL is a preparation CL for an upcoming
feature (https://crbug.com/396998476).

Bug: 396998476
Change-Id: I36f8acc88961a6f0b83e70510c1733e9a8afbbb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6275505
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Minoru Chikamune <chikamune@chromium.org>
Reviewed-by: Jiacheng Guo <gjc@google.com>
Cr-Commit-Position: refs/heads/main@{#1420962}
1 file changed
tree: 13b78f20687438201294fa740b937d8dc655f02d
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.