| commit | a4afa6081858a79b571e1573f473b24a54cc806c | [log] [tgz] |
|---|---|---|
| author | Dan McArdle <dmcardle@chromium.org> | Mon Nov 15 21:04:02 2021 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Nov 15 21:04:02 2021 |
| tree | 8feb8d62856202fba8f592d22950a0f16f6e49a3 | |
| parent | 3960bf988a28a48459cccf38ca0675d91fe412de [diff] |
Add warning to base::BarrierCallback about reference elision BarrierCallback's doc comment states that when T is a reference, it drops the reference and moves/copies the underlying value type. Under the hood, this is accomplished with the magical base::remove_cvref. It's easy not to realize that the references contained within types, like std::pair<const Foo&, const Bar&>, will not be converted to their value types because base::remove_cvref only operates on the top type. To be clear, this is just an easy mistake that callers might make. It's not quite a footgun, nor is it something that BarrierCallback could guard against with incantations of template magic. I ran into this sharp edge in another CL, and figured it deserves a short warning: https://chromium-review.googlesource.com/c/chromium/src/+/3226048/14 Change-Id: I20f58e8ae77b525dfe522b89f170ae04287eaa4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3252025 Reviewed-by: Chris Fredrickson <cfredric@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/main@{#941833}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.