Google GitGoogle Git
Sign in
chromium/chromium/src/a4c49ce3d10c11593c640f3674597517427367a0
commit
a4c49ce3d10c11593c640f3674597517427367a0
[log]
author
S. Ganesh <ganesh@chromium.org>
Wed Nov 15 02:04:25 2023
committer
Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>
Wed Nov 15 02:04:25 2023
tree
d766cb993e6d48dd6ffc90bd62de1eb51a5a35b1
parent
01fe252bf8c0509f834ab090b4e237c0035e84bd [diff]
Fix DIR_PROGRAM_FILES6432 to return correct path on Arm64

Adding a check for Arm64 in addition to X64 before getting the
variable `ProgramW6432`.

Test fails without this change on arm64:
https://chrome-swarming.appspot.com/task?id=65e91a0ca87d8810

Test passes with this change on arm64:
https://chrome-swarming.appspot.com/task?id=65e91e0d83396310

Bug: 1502287
Change-Id: I9ca597ead5fda9b4282bfa493dc17a39cc900cca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5030977
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: S Ganesh <ganesh@chromium.org>
Commit-Queue: S Ganesh <ganesh@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1224694}
2 files changed
tree: d766cb993e6d48dd6ffc90bd62de1eb51a5a35b1
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .eslintrc.js
  60. .git-blame-ignore-revs
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. DEPS
  75. DIR_METADATA
  76. LICENSE
  77. LICENSE.chromium_os
  78. OWNERS
  79. PRESUBMIT.py
  80. PRESUBMIT_test.py
  81. PRESUBMIT_test_mocks.py
  82. README.md
  83. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.