Don't synthesize page load on navigations that used to get ignored We no longer ignore navigations (NAVIGATION_TYPE_NAV_IGNORE, where we commit the navigation but don't actually create a NavigationEntry for the navigation) after crrev.com/c/3237491 and crrev.com/c/3237493. This can cause NavigationStateChanged calls to be fired in more occasions than before, which can result in more onPageStarted, onPageFinished etc calls on Android WebView (through postSynthesizedPageLoadingForUrlBarUpdate) which is unexpected for some apps (see linked bug). This CL marks the navigations that used to get ignored and NavigationEntries that used to not exist before the introduction of initial NavigationEntries, so that WebView can preserve its old behavior by continuing to "ignore" the marked NavigationStateChanged calls. Bug: 1277414 Change-Id: I82692bae155775ff95ecf720b7ccd86b61d51467 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3347483 Reviewed-by: Richard Coles <torne@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/main@{#953393}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.