Google Git
Sign in
chromium / chromium / src / a4f070a250a59c3765b319743312a377238a0a57
commita4f070a250a59c3765b319743312a377238a0a57[log] [tgz]
authorDavid Maunder <davidjm@google.com>Tue Jun 04 00:54:03 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Jun 04 00:54:03 2024
treeafb2b1dfac36967401c8ee9b4f731b2c364677eb
parent2ff4f946284e0da422aa21fda3ea5abe4a802d86 [diff]
Legacy and FlatBuffer TabState parity on TabPersistentStore#saveState

It's an edge case but currently TabPersistentStore#saveState can end up
with Legacy/FlatBuffer TabState inconsistency. For example, if we
have a pending save for a Tab, TabPersistentStore#saveState will
save legacy TabState but not FlatBuffer TabState. It's possible an
earlier version of the TabState was stored to the FlatBuffer file. So
when the user restarts they will get a previous snapshot of their Tab.
This change ensures we save FlatBuffer TabState if
1) saveState() saves a pending Tab Save
2) If there's a pending migration in the queue for which a FlatBuffer
file already exists (to ensure we're not in a state on startup where
a previous snapshot would be restored).

Bug: b:344029269
Change-Id: Iaeeb7589098779941db54c8814fd0fd729859d1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5591710
Commit-Queue: David Maunder <davidjm@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1309720}
3 files changed
tree: afb2b1dfac36967401c8ee9b4f731b2c364677eb
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.