Correctly round up doubles in NQE static_cast<int64_t>(std::ceil(...)) is not a safe way to round doubles: https://luci-milo.appspot.com/ui/inv/build-8752555092756764593/test-results?q=NetworkQualityEstimatorTest.TestEffectiveConnectionTypeObserver&sortby=&groupby= https://groups.google.com/a/chromium.org/g/chromium-dev/c/2c7HGlprD1E/m/bkFFt5LkAgAJ Use base::ClampCeil instead. Also the output variable here is an int32_t, not an int64_t. Bug: 40942951 Change-Id: Ia9ab685c183908c9315055b31819a1ee2b713dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5390944 Reviewed-by: Adam Rice <ricea@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/main@{#1277480}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.