Google Git
Sign in
chromium / chromium / src / a5061bcf911d59bb5aa2d6ea29fdc20f5011982d
commita5061bcf911d59bb5aa2d6ea29fdc20f5011982d[log] [tgz]
authorHiroshige Hayashizaki <hiroshige@chromium.org>Thu Aug 26 00:50:50 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Aug 26 00:50:50 2021
treeff891636c6dcbaab943271777a0b463df2c8f2a0
parent33ddffa9b476ab44623274e7313a8028f19ddd9b [diff]
Fix prefinalize check failure in ResourceClient

This CL avoids calling ResourceClinet::RemoveClient()
and Contains() calls inside it (that would cause
check failures in V8 side) during prefinalizer, by
calling DidRemoveClientOrObserver() instead.

This CL adds unit tests that would fail with
https://chromium-review.googlesource.com/c/v8/v8/+/3099953 and
`v8_enable_debugging_features` enabled.

Bug: 1241773
Change-Id: I8e7b63970b755df67a1a909bcc27b12abc4e8e78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3111576
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/main@{#915412}
5 files changed
tree: ff891636c6dcbaab943271777a0b463df2c8f2a0
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.