commit | a5200e2a5530b51c14eee9c66025af044c8f90f8 | [log] [tgz] |
---|---|---|
author | Artem Sumaneev <asumaneev@google.com> | Thu Jul 07 12:10:22 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Jul 07 12:10:22 2022 |
tree | 744d820bb639a4040b1dcf446ef26dd1ffd6bcdd | |
parent | a707fd5b26acda02ae2451470e3e8370827780bd [diff] |
[Enrolment] Delete AutoEnrollmentClient instantly. Remove CancelAndDeleteSoon from AutoEnrollmentClient so it's lifetime is obvious and it's deleted instantly once it's not needed anymore. The feature was used to measure extra time of hash dance protocol which is not a case anymore. AutoEnrollmentController used to release the client on safeguard timeout when the client took too long to check server state. If the check was not enforced, the controller released the client and reported "no enrollment" so the user could proceed using the device. If the check was enforced, the controller released the client and waited for input for another attempt with a new client. Now, the controller does the same but instead of releasing the client it destroys the client. Additionally, a very unlikely scenario is not possible anymore: the released client could retrieve the server state while the controller was awaiting retry. The new client would use local state and send no requests to the server. Now there's no released clients and the new requests will be definitely sent. Bug: chromium:1294843 Test: unit_tests --gtest_filter="*AutoEnrollmentClientImplTest*" Test: unit_tests --gtest_filter="*AutoEnrollmentClientImplFREToInitialEnrollmentTest*" Test: unit_tests --gtest_filter="*PsmHelperInitialEnrollmentTest*" Test: manual on device Change-Id: Ide36b19fbe32ad5d7d28ea7047384d5298986c31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3676866 Reviewed-by: Amr Aboelkher <amraboelkher@chromium.org> Commit-Queue: Artem Sumaneev <asumaneev@google.com> Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/main@{#1021626}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.