[Enrolment] Delete AutoEnrollmentClient instantly.

Remove CancelAndDeleteSoon from AutoEnrollmentClient so it's lifetime is
obvious and it's deleted instantly once it's not needed anymore. The
feature was used to measure extra time of hash dance protocol which
is not a case anymore.

AutoEnrollmentController used to release the client on safeguard timeout
when the client took too long to check server state. If the check was
not enforced, the controller released the client and reported "no
enrollment" so the user could proceed using the device. If the check was
enforced, the controller released the client and waited for input for
another attempt with a new client.

Now, the controller does the same but instead of releasing the client it
destroys the client.

Additionally, a very unlikely scenario is not possible anymore: the
released client could retrieve the server state while the controller was
awaiting retry. The new client would use local state and send no
requests to the server. Now there's no released clients and the new
requests will be definitely sent.

Bug: chromium:1294843
Test: unit_tests --gtest_filter="*AutoEnrollmentClientImplTest*"
Test: unit_tests --gtest_filter="*AutoEnrollmentClientImplFREToInitialEnrollmentTest*"
Test: unit_tests --gtest_filter="*PsmHelperInitialEnrollmentTest*"
Test: manual on device
Change-Id: Ide36b19fbe32ad5d7d28ea7047384d5298986c31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3676866
Reviewed-by: Amr Aboelkher <amraboelkher@chromium.org>
Commit-Queue: Artem Sumaneev <asumaneev@google.com>
Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1021626}
7 files changed
tree: 744d820bb639a4040b1dcf446ef26dd1ffd6bcdd
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.