commit a537beebb1e093f82c32b1dccfab5337d53a8728
author Colin Blundell <blundell@chromium.org> Wed Feb 12 07:52:46 2025
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Feb 12 07:52:46 2025
tree ec598f6781274514abba663d52cefaae68340494
parent 2762d0670333eb5ba33d037d76c177de0ec9e2bb

[Blink] Fix fragility in CanvasResourceProvider::OnMemoryDump() flow

CanvasResourceProvider::OnMemoryDump() currently short-circuits out if
CanvasResource::HasDetailedMemoryDumpProvider() returns true. However,
that's not actually how the architecture works here:

* CanvasResourceSharedImage is the only CanvasResource subclass that
  overrides that method to return true
* It provides an OnMemoryDump() method
* CanvasResourceProviderSharedImage overrides OnMemoryDump() to call
  into the method of its resources [1]

If any other CanvasResource subclasses wanted to replicate this
architecture, they'd have to do the same thing - they wouldn't get
anything from overriding HasDetailedMemoryDumpProvider() on its own
other than losing memory dump providing altogether :P. This CL removes
the misleading method.

[1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/graphics/canvas_resource_provider.cc;l=807-825?q=CanvasResourceProviderSharedImage::OnM&ss=chromium

Bug: 379996128
Change-Id: I3e8bc42458bb854ebffd46f240fefd97c06ac13d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6253280
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1419136}