Google Git
Sign in
chromium / chromium / src / a53ea3f89cecd2e85a4b511075612d825f40ceee
commita53ea3f89cecd2e85a4b511075612d825f40ceee[log] [tgz]
authorIoana Pandele <ioanap@chromium.org>Mon May 31 17:27:35 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon May 31 17:27:35 2021
tree66695c91604ef6fb3e4b5b1fca16e0d22c89ec41
parent91abb4b9bdecc2801e0f367f7c182b5b7d38809c [diff]
Revert "[PwdEditAndroid]Don't handle text changes before the model is initialized"

This reverts commit ef80ae82594fad3297011c281a28c5378a6b39f7.

Reason for revert: This doesn't fix the issue. 

Original change's description:
> [PwdEditAndroid]Don't handle text changes before the model is initialized
>
> Sometimes text change events fire before the initial text is even set on the
> field. This causes an empty string to be set on the model instead of the
> password. Checking if the model is initialized before handling a text
> change should fix the issue.
>
> Bug: 1213843
> Change-Id: I2ec590ec0c37a9f7d36d6128daed8a311ca30071
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2919759
> Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
> Commit-Queue: Ioana Pandele <ioanap@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#887156}

Bug: 1213843
Change-Id: Iefeedbb52f405eb1f43e8231da88d0e1d4e0e8f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2927605
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#887777}
2 files changed
tree: 66695c91604ef6fb3e4b5b1fca16e0d22c89ec41
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.