Google Git
Sign in
chromium / chromium / src / a576139534537ed3198df5d711164dfdf7b50242
commita576139534537ed3198df5d711164dfdf7b50242[log] [tgz]
authorBenjamin Keen <bkeen@google.com>Fri Jun 28 22:56:58 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Jun 28 22:56:58 2024
treee28297105adcb2706bba16d72d0c59bb6c730591
parent7064675fa9edfe79459d8651950a1cee8a98b42c [diff]
Reland "Prevent WebApps from overwriting document PiP windows initial size"

Fix test by avoiding out-of-app-scope navigation

This is a reland of commit 9951ee806b565ec36f8a7d6f74fadc84ead9cabd

Original change's description:
> Prevent WebApps from overwriting document PiP windows initial size
>
> This change updates `AppBrowserController::OnReceivedInitialURL` to
> ignore document picture in picture windows, since these bounds are
> calculated and set by the `PictureInPictureBrowserFrameView`.
>
> This fixes a bug where the requested PiP window inner size would not be
> honored.
>
> Bug: 348476064, 41459774
> Change-Id: I19bba8b5383c48db4f04052af21917a60857d619
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5656392
> Commit-Queue: Benjamin Keen <bkeen@google.com>
> Reviewed-by: Frank Liberato <liberato@chromium.org>
> Reviewed-by: Daniel Murphy <dmurph@chromium.org>
> Reviewed-by: Chase Phillips <cmp@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1320089}

Bug: 348476064, 41459774, 349694499
Change-Id: Ib247cf556eb6e3e7f402141cc256694e4f98e14c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5668220
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Benjamin Keen <bkeen@google.com>
Cr-Commit-Position: refs/heads/main@{#1321237}
3 files changed
tree: e28297105adcb2706bba16d72d0c59bb6c730591
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.