Google Git
Sign in
chromium / chromium / src / a57a94c02ae05636d670ddfb4373d25c7d13a0f7
commita57a94c02ae05636d670ddfb4373d25c7d13a0f7[log] [tgz]
authordljames <dljames@google.com>Tue Jan 30 22:41:57 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Jan 30 22:41:57 2024
tree2a7744c885cfffcb6a8ec0b272297e120f82327a
parentf2e8e3ef902284542ea47c30cd5dd1686db331a8 [diff]
[ Extensions ] Fix tabGroups.Move bug with adjacent groups

Fixes a bug that prevents extensions from moving a tab group to the right of another one due to an off by one error.

Fixing this caused a few other call sites to fail since they had implemented similar work-arounds.

The current way we calculate the index to move a tab group is by pretending the group and all of its tabs have been removed from the Tabstrip. The left over tabs represent the available indices we could move the group to (except for indices in the middle of another group).

Because there was an off by one error in the tab group extensions API and the case (moving a group to the right of another group) was unhandled in the TabstripModel, this has gone mostly unnoticed since their effects canceled each other out in most cases.

Regression tests are added in tab_groups_api_unittest for this scenario.

Change-Id: I92d8350157ab2ff23a6970bb5fe0ce4c15f5e881
Bug: 1417493
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5225325
Reviewed-by: Yuheng Huang <yuhengh@chromium.org>
Commit-Queue: Darryl James <dljames@chromium.org>
Reviewed-by: Taylor Bergquist <tbergquist@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1254231}
7 files changed
tree: 2a7744c885cfffcb6a8ec0b272297e120f82327a
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.